Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] added composer for managing external libraries #27

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

othmar52
Copy link
Contributor

@othmar52 othmar52 commented Dec 17, 2016

added composer for managing external libraries.

This pull-request is related to #26, #21

on your development instances you can run ./composer.phar update to fetch the configured versions of external libraries. To keep O!MPD's repo size as small as possible i have added an additional deploy-script which copies only required files from vendor into vendor-dist based on scripts/deploy-vendor.txt. Stuff like demos, unminified version, git-repos, etc won't be included in O!MPD repository

so after adding/updating external libraries you have to run ./scripts/deploy-vendor.sh

instead of processing the whole music collection within on mysql-fetch-loop smaller
batchsizes gets processed. now there is NO(!!!) memory growth within importer-phase
fileInfo() at all.
Unfortunately the memory-usage of the previous importer-phase (fileStructure) is
still a problematic starting point for fileInfo()

further some massive code-cleanup regarding tag-processing had been done.
TODO: make use of the new tag-processing where needed to remove duplicate code-mess
TODO: refactoring fileStructure() in terms of memory consumption
@othmar52
Copy link
Contributor Author

Hi Artur,
Regardless of those merge conflicts - what is your opinion about having composer in O!MPD?
do you like the idea?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant